[chromedriver] Include extension popups in list of windows

[chromedriver] Include extension popups in list of windows

BUG=

Committed: https://crrev.com/3eca6c2a54a749339fc5358d0b64c2e4e2beeebd
Cr-Commit-Position: refs/heads/master@{#308215}

[samuong, 2014-12-12 23:07:29]

samuong@chromium.org changed reviewers:
+ stgao@chromium.org

[stgao, 2014-12-12 23:51:34]

lgtm in general

As we discussed, below are two suggestions:
1. Make DevTools return a new page type for extension popup.
2. Enable this feature behind an experimental/temporary capability or command
line switch, otherwise some java tests will fail.

[stgao, 2014-12-12 23:54:42]

oh, for the second point. It might be backgroud page, next extension popup.

[samuong, 2014-12-13 00:06:33]

On 2014/12/12 23:54:42, Shuotao wrote:
> oh, for the second point. It might be backgroud page, next extension popup.

I just ran java_tests on my linux box and didn't get any new failures. This
change won't do anything for background pages, just "other" pages that are part
of extensions (e.g. popups). So as we discussed we don't need to hide this
behind a capability.

And also as discussed, I'll talk to the DevTools team about adding a new page
type if we decide to make this change permanent.

[samuong, 2014-12-13 00:06:34]

The CQ bit was checked by samuong@chromium.org

[commit-bot: I haz the power, 2014-12-13 00:08:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/802803002/1

[commit-bot: I haz the power, 2014-12-13 01:33:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-13 01:33:52]

Patchset 1 (id:??) landed as
https://crrev.com/3eca6c2a54a749339fc5358d0b64c2e4e2beeebd
Cr-Commit-Position: refs/heads/master@{#308215}