Add image decoding mode to DM.

Add image decoding mode to DM.

This is meant to supplant skimage.

BUG=skia:3235
Committed: https://skia.googlesource.com/skia/+/f6139f7c3867a70a750620cd34ce10338a54086e

[mtklein, 2014-12-12 23:01:44]

mtklein@google.com changed reviewers:
+ mtklein@google.com, scroggo@google.com

[mtklein, 2014-12-12 23:04:26]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-12-12 23:04:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/802793002/40001

[commit-bot: I haz the power, 2014-12-12 23:04:51]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-12-13 05:04 UTC

[commit-bot: I haz the power, 2014-12-12 23:06:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-12 23:06:42]

Try jobs failed on following builders:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia
(http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)
  Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86...)

[scroggo, 2014-12-12 23:40:59]

lgtm modulo build failures (and using more image suffixes/all files).

https://codereview.chromium.org/802793002/diff/40001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/802793002/diff/40001/dm/DM.cpp#newcode172
dm/DM.cpp:172: exit(1);
I know we already do this for SKPs, but why do we early exit like this? Why not
log a failure and still run the rest of the tests?

https://codereview.chromium.org/802793002/diff/40001/dm/DM.cpp#newcode252
dm/DM.cpp:252: const char* suffixes[] = { "bmp", "gif", "jpg", "png", "webp",
"ktx", "astc" };
Ultimately we'll want more types than this (wbmp, ico). And sometimes jpg have
other endings. Why not just all files from the folder?

https://codereview.chromium.org/802793002/diff/40001/dm/DMImageTask.cpp
File dm/DMImageTask.cpp (right):

https://codereview.chromium.org/802793002/diff/40001/dm/DMImageTask.cpp#newco...
dm/DMImageTask.cpp:54: composite.eraseColor(0x00000000);
I think there is a color for this.

[mtklein, 2014-12-13 00:32:24]

https://codereview.chromium.org/802793002/diff/40001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/802793002/diff/40001/dm/DM.cpp#newcode172
dm/DM.cpp:172: exit(1);
On 2014/12/12 23:40:59, scroggo wrote:
> I know we already do this for SKPs, but why do we early exit like this? Why
not
> log a failure and still run the rest of the tests?

Mostly, if we can list the file but not read it, your machine or the bot is
somehow royally hosed, and it's better to find that out loudly right away than
struggle through.

https://codereview.chromium.org/802793002/diff/40001/dm/DM.cpp#newcode252
dm/DM.cpp:252: const char* suffixes[] = { "bmp", "gif", "jpg", "png", "webp",
"ktx", "astc" };
On 2014/12/12 23:40:59, scroggo wrote:
> Ultimately we'll want more types than this (wbmp, ico). And sometimes jpg have
> other endings. Why not just all files from the folder?

Hmm.  There's junk in resources that's not images (fonts, lua scripts).  I
figure explicitly listing the types of files we expect to be able to decode lets
us call a failure to decode an error.  If we were reading all files, skipping
those we can't decode, we might not notice when an image that used to decode
properly stopped decoding.

https://codereview.chromium.org/802793002/diff/40001/dm/DMImageTask.cpp
File dm/DMImageTask.cpp (right):

https://codereview.chromium.org/802793002/diff/40001/dm/DMImageTask.cpp#newco...
dm/DMImageTask.cpp:54: composite.eraseColor(0x00000000);
On 2014/12/12 23:40:59, scroggo wrote:
> I think there is a color for this.

So there is.  Done.

[mtklein, 2014-12-13 00:32:30]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-12-13 00:32:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/802793002/60001

[commit-bot: I haz the power, 2014-12-13 00:41:18]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f6139f7c3867a70a750620cd34ce10338a54086e