Issue 802713002: Handle SkBitmaps which have no pixels in SkPDFImage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 802713002: Handle SkBitmaps which have no pixels in SkPDFImage. (Closed)

Created:
6 years ago by jbroman

Modified:
6 years ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Handle SkBitmaps which have no pixels in SkPDFImage. A test that ensures this no longer crashes has been added. BUG=skia:3232 Committed: https://skia.googlesource.com/skia/+/160715668957925d99440ac6aa10d3219b9b29b4

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -2 lines)			Patch
M	gyp/tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pdf/SkPDFImage.cpp	View	2 chunks	+5 lines, -2 lines	0 comments	Download
A	tests/PDFInvalidBitmapTest.cpp	View	1 chunk	+60 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

jbroman

Noticed that the invalid PNG I was using to debug another issue in Chromium (search ...

6 years ago (2014-12-12 17:03:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802713002/1

6 years ago (2014-12-12 19:20:05 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-12 19:28:19 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/160715668957925d99440ac6aa10d3219b9b29b4