Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 802683002: Revert of Use Surfaces on Windows, Linux, and Mac OS (second try) (Closed)

Created:
6 years ago by lushnikov
Modified:
6 years ago
Reviewers:
jbauman, piman
CC:
chromium-reviews, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, jamesr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use Surfaces on Windows, Linux, and Mac OS (second try) (patchset #1 id:1 of https://codereview.chromium.org/796693003/) Reason for revert: Speculative revert: virtual/slimmingpaint/fast/text/fallback-traits-fixup.html is crashing on Mac. Example build: http://goo.gl/Ol8CHS Flakiness dashboard: http://goo.gl/KGLmLS Original issue's description: > Use Surfaces on Windows, Linux, and Mac OS (second try) > > Surfaces should be feature-complete, so try enabling them on Windows, Linux, and Mac OS. They're still disabled on Chrome OS because they rely on single-threaded browser compositing, and on Android because they haven't been implemented there yet. > > BUG=334090 > TBR=piman@chromium.org > > Committed: https://crrev.com/8a61bd41b8a04bde04d7b538e3d9a42acd7c4ec7 > Cr-Commit-Position: refs/heads/master@{#308028} TBR=piman@chromium.org,jbauman@chromium.org NOTREECHECKS=true NOTRY=true BUG=334090 Committed: https://crrev.com/6cbc94f3715120db2019fb5ae0a593cfadb9152e Cr-Commit-Position: refs/heads/master@{#308068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 chunk +6 lines, -13 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
lushnikov
Created Revert of Use Surfaces on Windows, Linux, and Mac OS (second try)
6 years ago (2014-12-12 14:23:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802683002/1
6 years ago (2014-12-12 14:24:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 14:25:50 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-12 14:26:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cbc94f3715120db2019fb5ae0a593cfadb9152e
Cr-Commit-Position: refs/heads/master@{#308068}

Powered by Google App Engine
This is Rietveld 408576698