Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 802673002: Revert of Isolate remaining tests under ui/ (Closed)

Created:
6 years ago by M-A Ruel
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Isolate remaining tests under ui/ (patchset #21 id:400001 of https://codereview.chromium.org/724603004/) Reason for revert: Speculatively reverting due to chromium.win not triggered testers at all. http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/5439/ succeeded in triggering testers http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/5440/ didn't. There was no build.git commit nor recipe change. BUG=441690 Original issue's description: > Isolate remaining tests under ui/ > > BUG=98637 > R=maruel@chromium.org,jam@chromium.org > > Committed: https://crrev.com/4d293d79bd67b683942fd727c46f2b3173d7f03e > Cr-Commit-Position: refs/heads/master@{#307954} TBR=jam@chromium.org,phajdan.jr@chromium.org,jochen@chromium.org NOTREECHECKS=true NOTRY=true BUG=98637 Committed: https://crrev.com/42f9c67b74278051466a2f63d087e6750bd27c53 Cr-Commit-Position: refs/heads/master@{#308066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -859 lines) Patch
M testing/buildbot/chromium.linux.json View 9 chunks +15 lines, -90 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 16 chunks +20 lines, -120 lines 0 comments Download
M testing/buildbot/chromium.win.json View 18 chunks +23 lines, -138 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 4 chunks +6 lines, -36 lines 0 comments Download
M ui/accessibility/accessibility.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/accessibility/accessibility_unittests.isolate View 1 chunk +0 lines, -20 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/app_list/app_list_unittests.isolate View 1 chunk +0 lines, -69 lines 0 comments Download
M ui/base/ui_base_tests.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/base/ui_base_unittests.isolate View 1 chunk +0 lines, -79 lines 0 comments Download
M ui/events/events.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/events/events_unittests.isolate View 1 chunk +0 lines, -68 lines 0 comments Download
M ui/gfx/gfx_tests.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/gfx/gfx_unittests.isolate View 1 chunk +0 lines, -22 lines 0 comments Download
M ui/message_center/message_center.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/message_center/message_center_unittests.isolate View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
Created Revert of Isolate remaining tests under ui/
6 years ago (2014-12-12 14:01:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802673002/1
6 years ago (2014-12-12 14:02:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 14:03:33 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-12 14:04:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42f9c67b74278051466a2f63d087e6750bd27c53
Cr-Commit-Position: refs/heads/master@{#308066}

Powered by Google App Engine
This is Rietveld 408576698