pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart - Issue 802653005: dart2js: put all type-test related properties on the prototype and not on the constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

Issue 802653005: dart2js: put all type-test related properties on the prototype and not on the constructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Minor improvements Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart » ('j') | pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

index c52b465d4667a2c21d2f2f3b475a72feebd5b035..68e9b043b530145ab9fc6a7dddce55f7c76a05be 100644

--- a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

@@ -1703,7 +1703,6 @@ class OldEmitter implements Emitter {

emitFinishClassesInvocationIfNecessary(mainBuffer);

}

- typeTestEmitter.emitRuntimeTypeSupport(mainBuffer, mainOutputUnit);

interceptorEmitter.emitGetInterceptorMethods(mainBuffer);

interceptorEmitter.emitOneShotInterceptors(mainBuffer);

@@ -2172,7 +2171,6 @@ function(originalDescriptor, name, holder, isStatic, globalFunctionsAccess) {

// point to the current Isolate. Otherwise all methods/functions

// accessing isolate variables will access the wrong object.

outputBuffer.write("${namer.currentIsolate}$_=${_}arguments[1]$N");

- typeTestEmitter.emitRuntimeTypeSupport(outputBuffer, outputUnit);

emitCompileTimeConstants(outputBuffer, outputUnit);

emitStaticNonFinalFieldInitializations(outputBuffer, outputUnit);