Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 802653003: Convert EventRouter to use ProcessMap::GetMostLikelyContextType rather than (Closed)

Created:
6 years ago by not at google - send to devlin
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert EventRouter to use ProcessMap::GetMostLikelyContextType rather than implementing its own process checking logic, and (double) check on event dispatch that the context has permission to receive the event. Currently we only check on event registration. BUG=441789 R=rockot@chromium.org Committed: https://crrev.com/100aea413ed702bc7d7814c7fd64e9f922cc3272 Cr-Commit-Position: refs/heads/master@{#308727}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : delete some code! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -143 lines) Patch
M chrome/common/extensions/api/extension_api_unittest.cc View 1 2 1 chunk +0 lines, -95 lines 0 comments Download
M extensions/browser/event_router.cc View 1 2 4 chunks +31 lines, -30 lines 0 comments Download
M extensions/common/extension_api.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/common/extension_api.cc View 1 2 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
not at google - send to devlin
Please [triple] check this.
6 years ago (2014-12-16 03:40:29 UTC) #6
Ken Rockot(use gerrit already)
I'm wondering if there's some way we can unify the logic here with the logic ...
6 years ago (2014-12-16 17:36:05 UTC) #7
not at google - send to devlin
On 2014/12/16 17:36:05, Ken Rockot (OOO until Jan 5) wrote: > I'm wondering if there's ...
6 years ago (2014-12-17 00:19:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802653003/120001
6 years ago (2014-12-17 00:20:23 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:120001)
6 years ago (2014-12-17 02:19:51 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-17 02:20:54 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/100aea413ed702bc7d7814c7fd64e9f922cc3272
Cr-Commit-Position: refs/heads/master@{#308727}

Powered by Google App Engine
This is Rietveld 408576698