Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 802633005: replace COMPILE_ASSERT with static_assert in public/platform/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
philipj_slow
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in public/platform/ BUG=442514 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187275

Patch Set 1 #

Patch Set 2 : improve static_assert msgs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M public/platform/WebDeviceMotionData.h View 1 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebDeviceOrientationData.h View 1 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebGamepad.h View 1 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebGamepads.h View 1 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebPrivateOwnPtr.h View 1 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebPrivatePtr.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mostyn Bramley-Moore
@Philip: PTAL, this is required before I can remove the COMPILE_ASSERT macro.
6 years ago (2014-12-16 11:47:23 UTC) #2
philipj_slow
lgtm
6 years ago (2014-12-16 14:59:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802633005/20001
6 years ago (2014-12-16 16:00:51 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-16 17:15:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187275

Powered by Google App Engine
This is Rietveld 408576698