Issue 802633003: leveldb: Added dumpfile to *.gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 802633003: leveldb: Added dumpfile to *.gyp (Closed)

Created:
6 years ago by cmumford

Modified:
6 years ago

Reviewers:
michaeln

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

leveldb: Added dumpfile to *.gyp Needed for leveldb_main utility program to link. Committed: https://crrev.com/0cdd39fd41f250bae357bf2b4e14a4e09332f72f Cr-Commit-Position: refs/heads/master@{#308476}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	third_party/leveldatabase/leveldatabase.gyp	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

cmumford

Alphabetizing of filename.cc unrelated. Let me know if you want it in another CL.

6 years ago (2014-12-15 23:15:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802633003/1

6 years ago (2014-12-15 23:31:26 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-16 00:44:56 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0cdd39fd41f250bae357bf2b4e14a4e09332f72f
Cr-Commit-Position: refs/heads/master@{#308476}