Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 80263005: Use RemoteInputMethodWin in production (Closed)

Created:
7 years, 1 month ago by yukawa
Modified:
7 years, 1 month ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, nona+watch_chromium.org, James Su, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use RemoteInputMethodWin in production With this CL, InputMethodIMM32 will be replaced with RemoteInputMethodWin when and only when the target window is remote window used by Metro/Ash. There should be no effect for other platforms and desktop Chrome on Windows. The goal of this CL is testing RemoteInputMethodWin in Canary channel. Ideally there should be no regression, even though subsequent CLs are still needed to enable IME under Ash mode. Sheriffs: Feel free to revert this CL if it breaks something. BUG=164964 TEST=manually done on Windows 8.1 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236708

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M ui/base/ime/input_method_factory.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/base/ime/remote_input_method_win.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/base/ime/remote_input_method_win.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yukawa
7 years, 1 month ago (2013-11-21 10:47:39 UTC) #1
Seigo Nonaka
lgtm
7 years, 1 month ago (2013-11-21 23:37:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/80263005/70001
7 years, 1 month ago (2013-11-22 00:56:13 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=193615
7 years, 1 month ago (2013-11-22 02:51:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/80263005/70001
7 years, 1 month ago (2013-11-22 03:43:21 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=99876
7 years, 1 month ago (2013-11-22 06:06:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/80263005/70001
7 years, 1 month ago (2013-11-22 06:24:16 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 07:20:40 UTC) #8
Message was sent while issue was closed.
Change committed as 236708

Powered by Google App Engine
This is Rietveld 408576698