Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2171)

Unified Diff: Source/modules/webaudio/AudioSummingJunction.cpp

Issue 802593004: WebAudio: Fix AudioNode leak in a case that AudioNode is not disconnected from the graph explicitly. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webaudio/AudioSummingJunction.cpp
diff --git a/Source/modules/webaudio/AudioSummingJunction.cpp b/Source/modules/webaudio/AudioSummingJunction.cpp
index d61e27fb7fbcabdf3a39db5af7ad5b4f14f54d50..03d26c80f1a5504352597e178e897e5b5c042ae9 100644
--- a/Source/modules/webaudio/AudioSummingJunction.cpp
+++ b/Source/modules/webaudio/AudioSummingJunction.cpp
@@ -56,11 +56,6 @@ AudioSummingJunction::~AudioSummingJunction()
DEFINE_TRACE(AudioSummingJunction)
{
visitor->trace(m_context);
- // FIXME: Oilpan: m_renderingOutputs should not be strong references. This
- // is a short-term workaround to avoid crashes, and causes AudioNode leaks.
- AudioContext::AutoLocker locker(m_context);
- for (size_t i = 0; i < m_renderingOutputs.size(); ++i)
- visitor->trace(m_renderingOutputs[i]);
}
void AudioSummingJunction::changedOutputs()

Powered by Google App Engine
This is Rietveld 408576698