Disable ICF for order_profiling builds.

Disable ICF for order_profiling builds.

When we're profiling methods, we get back the address of the methods.  ICF
aliases several methods to the same address, which makes the order profile less
correct for other configurations which might make different ICF decisions.

Committed: https://crrev.com/0b32b53f9579ee6efe537723b652c03b89654fc3
Cr-Commit-Position: refs/heads/master@{#309439}

[azarchs, 2014-12-19 15:30:58]

azarchs@chromium.org changed reviewers:
+ pasko@chromium.org

[azarchs, 2014-12-19 15:30:59]

PTAL.  Is there a better way to do this?

[pasko, 2014-12-19 15:44:23]

It's a good enough GYP way, thanks. Please also change it in
build/config/compiler/BUILD.gn

[azarchs, 2014-12-19 16:43:40]

The GN builder does not appear to support order_profiling at all, currently. 
That should be fixed, but maybe in another CL?

[pasko, 2014-12-19 16:52:51]

lgtm

agreed, order profiling for GN is for later

[azarchs, 2014-12-19 16:56:46]

The CQ bit was checked by azarchs@chromium.org

[commit-bot: I haz the power, 2014-12-19 16:57:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/802583004/1

[commit-bot: I haz the power, 2014-12-19 17:04:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-19 17:04:04]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pasko, 2014-12-22 10:03:30]

pasko@chromium.org changed reviewers:
+ thakis@chromium.org

[pasko, 2014-12-22 10:17:12]

Nico: please rubber-stamp

[Nico, 2014-12-22 17:08:51]

rs-lgtm, but isn't that not-quite-right either? You probably want to use exactly
the same config for your release builder and the step that generates the
profile.

[pasko, 2014-12-22 17:18:26]

On 2014/12/22 17:08:51, Nico wrote:
> rs-lgtm, but isn't that not-quite-right either? You probably want to use
exactly
> the same config for your release builder and the step that generates the
> profile.

I am not worried here. With -finstrument-functions we departed so far in terms
of slowdown, that changing it more to introduce even 2x more unused functions (I
am exaggerating), does not sound like something affecting performance or
execution patterns. At the same time, more clarity in what was actually
executing, should help understanding/debugging.

[pasko, 2014-12-22 17:18:45]

The CQ bit was checked by pasko@chromium.org

[commit-bot: I haz the power, 2014-12-22 17:19:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/802583004/1

[commit-bot: I haz the power, 2014-12-22 17:51:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-22 17:52:32]

Patchset 1 (id:??) landed as
https://crrev.com/0b32b53f9579ee6efe537723b652c03b89654fc3
Cr-Commit-Position: refs/heads/master@{#309439}