sky/tools/webkitpy/layout_tests/controllers/test_result_writer_unittest.py - Issue 802573002: Prepare python code for reftests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/tools/webkitpy/layout_tests/controllers/test_result_writer_unittest.py

Issue 802573002: Prepare python code for reftests. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sky/tools/webkitpy/layout_tests/controllers/single_test_runner.py ('k') | sky/tools/webkitpy/layout_tests/models/test_expectations_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/tools/webkitpy/layout_tests/controllers/test_result_writer_unittest.py

diff --git a/sky/tools/webkitpy/layout_tests/controllers/test_result_writer_unittest.py b/sky/tools/webkitpy/layout_tests/controllers/test_result_writer_unittest.py

index 213b6779fde11183afa2362fbf7fe6116484ab5c..5b9d85ed156d74ed3f35ea00909863d549b93c4c 100644

--- a/sky/tools/webkitpy/layout_tests/controllers/test_result_writer_unittest.py

+++ b/sky/tools/webkitpy/layout_tests/controllers/test_result_writer_unittest.py

@@ -54,16 +54,16 @@ class TestResultWriterTests(unittest.TestCase):

def test_reference_exists(self):

failure = test_failures.FailureReftestMismatch()

- failure.reference_filename = '/src/exists-expected.html'

- files = {'/src/exists-expected.html': 'yup'}

+ failure.reference_filename = '/src/exists-expected.sky'

+ files = {'/src/exists-expected.sky': 'yup'}

written_files = self.run_test(failures=[failure], files=files)

- self.assertEqual(written_files, {'/tmp/exists-expected.html': 'yup'})

+ self.assertEqual(written_files, {'/tmp/exists-expected.sky': 'yup'})

failure = test_failures.FailureReftestMismatchDidNotOccur()

- failure.reference_filename = '/src/exists-expected-mismatch.html'

- files = {'/src/exists-expected-mismatch.html': 'yup'}

+ failure.reference_filename = '/src/exists-expected-mismatch.sky'

+ files = {'/src/exists-expected-mismatch.sky': 'yup'}

written_files = self.run_test(failures=[failure], files=files)

- self.assertEqual(written_files, {'/tmp/exists-expected-mismatch.html': 'yup'})

+ self.assertEqual(written_files, {'/tmp/exists-expected-mismatch.sky': 'yup'})

def test_reference_is_missing(self):

failure = test_failures.FailureReftestMismatch()