Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 802553003: Autofill dropdown icons: (Closed)

Created:
6 years ago by Evan Stade
Modified:
6 years ago
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, dcheng, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill dropdown icons: 1. Use camera icon for "Scan new card". 2. Fix regression where icon wasn't showing BUG=441534, 441533 TBR=jochen@chromium.org Committed: https://crrev.com/1f434d1737199bed791ac800651293573f7c48da Cr-Commit-Position: refs/heads/master@{#308425}

Patch Set 1 #

Total comments: 2

Patch Set 2 : ownership #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/android/resource_id.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/resources/autofill_scaled_resources.grdp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/android/java/res/layout/dropdown_item.xml View 1 chunk +2 lines, -1 line 0 comments Download
M ui/android/java/src/org/chromium/ui/DropdownAdapter.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
Evan Stade
6 years ago (2014-12-11 23:35:47 UTC) #2
Ted C
lgtm https://codereview.chromium.org/802553003/diff/1/ui/android/java/src/org/chromium/ui/DropdownAdapter.java File ui/android/java/src/org/chromium/ui/DropdownAdapter.java (right): https://codereview.chromium.org/802553003/diff/1/ui/android/java/src/org/chromium/ui/DropdownAdapter.java#newcode89 ui/android/java/src/org/chromium/ui/DropdownAdapter.java:89: // http://crbug.com/429364 Did you verify the above after ...
6 years ago (2014-12-12 22:48:02 UTC) #3
Evan Stade
https://codereview.chromium.org/802553003/diff/1/ui/android/java/src/org/chromium/ui/DropdownAdapter.java File ui/android/java/src/org/chromium/ui/DropdownAdapter.java (right): https://codereview.chromium.org/802553003/diff/1/ui/android/java/src/org/chromium/ui/DropdownAdapter.java#newcode89 ui/android/java/src/org/chromium/ui/DropdownAdapter.java:89: // http://crbug.com/429364 On 2014/12/12 22:48:02, Ted C wrote: > ...
6 years ago (2014-12-12 22:57:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802553003/1
6 years ago (2014-12-12 23:01:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/30211)
6 years ago (2014-12-13 00:16:03 UTC) #8
Evan Stade
TBR jochen for components/OWNERS
6 years ago (2014-12-15 19:36:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802553003/20001
6 years ago (2014-12-15 19:37:56 UTC) #11
Evan Stade
6 years ago (2014-12-15 19:42:43 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-15 21:34:40 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-15 21:36:16 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1f434d1737199bed791ac800651293573f7c48da
Cr-Commit-Position: refs/heads/master@{#308425}

Powered by Google App Engine
This is Rietveld 408576698