Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: runtime/vm/dart.cc

Issue 802543002: Move notification of isolate creation until after the ObjectStore is initialized. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/debugger.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/code_observers.h" 7 #include "vm/code_observers.h"
8 #include "vm/cpu.h" 8 #include "vm/cpu.h"
9 #include "vm/dart_api_state.h" 9 #include "vm/dart_api_state.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
11 #include "vm/debugger.h"
11 #include "vm/flags.h" 12 #include "vm/flags.h"
12 #include "vm/freelist.h" 13 #include "vm/freelist.h"
13 #include "vm/handles.h" 14 #include "vm/handles.h"
14 #include "vm/heap.h" 15 #include "vm/heap.h"
15 #include "vm/isolate.h" 16 #include "vm/isolate.h"
16 #include "vm/metrics.h" 17 #include "vm/metrics.h"
17 #include "vm/object.h" 18 #include "vm/object.h"
18 #include "vm/object_store.h" 19 #include "vm/object_store.h"
19 #include "vm/object_id_ring.h" 20 #include "vm/object_id_ring.h"
20 #include "vm/port.h" 21 #include "vm/port.h"
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 } 247 }
247 isolate->megamorphic_cache_table()->InitMissHandler(); 248 isolate->megamorphic_cache_table()->InitMissHandler();
248 249
249 isolate->heap()->EnableGrowthControl(); 250 isolate->heap()->EnableGrowthControl();
250 isolate->set_init_callback_data(data); 251 isolate->set_init_callback_data(data);
251 Api::SetupAcquiredError(isolate); 252 Api::SetupAcquiredError(isolate);
252 if (FLAG_print_class_table) { 253 if (FLAG_print_class_table) {
253 isolate->class_table()->Print(); 254 isolate->class_table()->Print();
254 } 255 }
255 256
256 257 isolate->debugger()->NotifyIsolateCreated();
257 Service::SendIsolateStartupMessage(); 258 Service::SendIsolateStartupMessage();
258 // Create tag table. 259 // Create tag table.
259 isolate->set_tag_table( 260 isolate->set_tag_table(
260 GrowableObjectArray::Handle(GrowableObjectArray::New())); 261 GrowableObjectArray::Handle(GrowableObjectArray::New()));
261 // Set up default UserTag. 262 // Set up default UserTag.
262 const UserTag& default_tag = UserTag::Handle(UserTag::DefaultTag()); 263 const UserTag& default_tag = UserTag::Handle(UserTag::DefaultTag());
263 isolate->set_current_tag(default_tag); 264 isolate->set_current_tag(default_tag);
264 265
265 return Error::null(); 266 return Error::null();
266 } 267 }
(...skipping 23 matching lines...) Expand all
290 return predefined_handles_->handles_.AllocateScopedHandle(); 291 return predefined_handles_->handles_.AllocateScopedHandle();
291 } 292 }
292 293
293 294
294 bool Dart::IsReadOnlyHandle(uword address) { 295 bool Dart::IsReadOnlyHandle(uword address) {
295 ASSERT(predefined_handles_ != NULL); 296 ASSERT(predefined_handles_ != NULL);
296 return predefined_handles_->handles_.IsValidScopedHandle(address); 297 return predefined_handles_->handles_.IsValidScopedHandle(address);
297 } 298 }
298 299
299 } // namespace dart 300 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/debugger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698