Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 802533002: Remove GG_VA_COPY in favor of va_copy (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GG_VA_COPY in favor of va_copy This was a workaround for VS's before 2013 that lack va_copy, and is no longer required. The unittest is removed as it seems unnecessary to test the standard library's implementation of va_copy. R=thakis@chromium.org TBR=cpu@chromium.org Committed: https://crrev.com/5cfb9efaa9d3b9b9d824d5809c0c6ede65757d4e Cr-Commit-Position: refs/heads/master@{#307991}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -60 lines) Patch
M base/port.h View 1 chunk +0 lines, -12 lines 2 comments Download
M base/strings/string_util_unittest.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M base/strings/stringprintf.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/cld/base/port.h View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/leveldatabase/chromium_logger.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
scottmg
6 years ago (2014-12-11 20:07:45 UTC) #1
Nico
lgtm
6 years ago (2014-12-11 20:11:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802533002/1
6 years ago (2014-12-11 20:14:58 UTC) #4
Mark Mentovai
LGTM
6 years ago (2014-12-11 20:17:34 UTC) #6
Mark Mentovai
https://codereview.chromium.org/802533002/diff/1/base/port.h File base/port.h (right): https://codereview.chromium.org/802533002/diff/1/base/port.h#newcode8 base/port.h:8: #include <stdarg.h> Remove this and #include it where stdarg ...
6 years ago (2014-12-11 20:19:36 UTC) #7
scottmg
https://codereview.chromium.org/802533002/diff/1/base/port.h File base/port.h (right): https://codereview.chromium.org/802533002/diff/1/base/port.h#newcode8 base/port.h:8: #include <stdarg.h> On 2014/12/11 20:19:36, Mark Mentovai wrote: > ...
6 years ago (2014-12-11 20:26:58 UTC) #8
scottmg
tbr cpu for third_party/ changes
6 years ago (2014-12-11 20:27:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-11 23:10:18 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-11 23:11:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cfb9efaa9d3b9b9d824d5809c0c6ede65757d4e
Cr-Commit-Position: refs/heads/master@{#307991}

Powered by Google App Engine
This is Rietveld 408576698