Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 802503003: Call _set_FMA3_enable(0); to work around VS 2013 CRT AVX bug. (Closed)

Created:
6 years ago by brucedawson
Modified:
6 years ago
Reviewers:
Lei Zhang, scottmg
CC:
chromium-reviews, scottmg, scherkus (not reviewing)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Call _set_FMA3_enable(0); to work around VS 2013 CRT AVX bug. BUG=436603 Committed: https://crrev.com/0438c513dc3c732fc1e53ef2818b325fb5dbca29 Cr-Commit-Position: refs/heads/master@{#307997}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M pdf/pdf.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
brucedawson
Same fix as done for other DLLs, with VC++ version check added.
6 years ago (2014-12-11 19:20:26 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/802503003/diff/1/pdf/pdf.cc File pdf/pdf.cc (right): https://codereview.chromium.org/802503003/diff/1/pdf/pdf.cc#newcode69 pdf/pdf.cc:69: #endif // ARCH_CPU_X86_64 nit: should match #if
6 years ago (2014-12-11 19:27:28 UTC) #3
scottmg
cl description should be 2013, not 2015
6 years ago (2014-12-11 19:33:45 UTC) #5
brucedawson
On 2014/12/11 19:33:45, scottmg wrote: > cl description should be 2013, not 2015 Good catches. ...
6 years ago (2014-12-11 20:00:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802503003/20001
6 years ago (2014-12-11 20:01:42 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-11 23:13:59 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-11 23:14:51 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0438c513dc3c732fc1e53ef2818b325fb5dbca29
Cr-Commit-Position: refs/heads/master@{#307997}

Powered by Google App Engine
This is Rietveld 408576698