Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 802483003: Cleanup: move elide_url_unittest.cc near its implementation source file. (Closed)

Created:
6 years ago by tfarina
Modified:
6 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: move elide_url_unittest.cc near its implementation source file. We don't separate unittests from the code they test, they usually live near the implementation, e.g.: chrome/browser/foo.h chrome/browser/foo.cc chrome/browser/foo_unittest.cc BUG=None TEST=unit_tests TBR=thestig@chromium.org Committed: https://crrev.com/dd792920e6e03cf79ca7a738df41e637de212e26 Cr-Commit-Position: refs/heads/master@{#308032}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -207 lines) Patch
A + chrome/browser/ui/elide_url_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/ui/tests/elide_url_unittest.cc View 1 chunk +0 lines, -201 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 5 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
TBRing... (rs?)
6 years ago (2014-12-11 23:50:39 UTC) #1
Lei Zhang
lgtm I don't know why you didn't say something on https://codereview.chromium.org/143463006 :-P https://codereview.chromium.org/802483003/diff/1/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi ...
6 years ago (2014-12-11 23:57:25 UTC) #2
tfarina
I did, heh :) Pushing to CQ! https://codereview.chromium.org/802483003/diff/1/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/802483003/diff/1/chrome/chrome_tests_unit.gypi#newcode2596 chrome/chrome_tests_unit.gypi:2596: On 2014/12/11 ...
6 years ago (2014-12-12 00:30:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802483003/20001
6 years ago (2014-12-12 00:32:57 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 02:36:11 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-12 02:37:12 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd792920e6e03cf79ca7a738df41e637de212e26
Cr-Commit-Position: refs/heads/master@{#308032}

Powered by Google App Engine
This is Rietveld 408576698