Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 802463002: Remove native_client_sdk from the PNG presubmit check (Closed)

Created:
6 years ago by binji
Modified:
6 years ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove native_client_sdk from the PNG presubmit check The native_client_sdk directory contains auto-generated documentation that includes PNGs that are flagged by the presubmit check. These PNGs are not used by Chrome, so they should be ignored by the check. BUG=150046 R=phajdan.jr@chromium.org Committed: https://crrev.com/0dcdf34d61c72798ad8949882efa2a42bf391cf3 Cr-Commit-Position: refs/heads/master@{#308125}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M PRESUBMIT.py View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
6 years ago (2014-12-11 18:19:20 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years ago (2014-12-12 10:34:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802463002/20001
6 years ago (2014-12-12 17:56:06 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 18:32:40 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-12 18:33:54 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0dcdf34d61c72798ad8949882efa2a42bf391cf3
Cr-Commit-Position: refs/heads/master@{#308125}

Powered by Google App Engine
This is Rietveld 408576698