Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 802453002: [android_webview] Split out an apk folder from the glue folder. (Closed)

Created:
6 years ago by mkosiba (inactive)
Modified:
6 years ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org, boliu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android_webview] Split out an apk folder from the glue folder. The reason for this separation is to distinguish the glue layer code (which is shared amongst all of the WebView .apks) from the apk-specific bits (which are not shared at all). BUG=440792 Committed: https://crrev.com/2bd10c6a723dba5ea1b5e308540a558147f42f82 Cr-Commit-Position: refs/heads/master@{#308074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -203 lines) Patch
M android_webview/android_webview.gyp View 2 chunks +34 lines, -1 line 0 comments Download
A + android_webview/apk/java/AndroidManifest.xml View 1 chunk +3 lines, -0 lines 0 comments Download
A + android_webview/apk/java/proguard.flags View 0 chunks +-1 lines, --1 lines 0 comments Download
A + android_webview/apk/java/res/drawable-hdpi/icon_webview.png View Binary file 0 comments Download
A + android_webview/apk/java/res/drawable-mdpi/icon_webview.png View Binary file 0 comments Download
A + android_webview/apk/java/res/drawable-xhdpi/icon_webview.png View Binary file 0 comments Download
A + android_webview/apk/java/res/drawable-xxhdpi/icon_webview.png View Binary file 0 comments Download
A + android_webview/apk/system_webview_apk_common.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
D android_webview/glue/android_webview_glue.gypi View 1 chunk +0 lines, -35 lines 0 comments Download
D android_webview/glue/android_webview_glue_common.gypi View 1 chunk +0 lines, -43 lines 0 comments Download
D android_webview/glue/java/AndroidManifest.xml View 1 chunk +0 lines, -20 lines 0 comments Download
D android_webview/glue/java/proguard.flags View 1 chunk +0 lines, -101 lines 0 comments Download
D android_webview/glue/java/res/drawable-hdpi/ic_media_video_poster.png View Binary file 0 comments Download
D android_webview/glue/java/res/drawable-hdpi/icon_webview.png View Binary file 0 comments Download
D android_webview/glue/java/res/drawable-ldpi/ic_media_video_poster.png View Binary file 0 comments Download
D android_webview/glue/java/res/drawable-mdpi/ic_media_video_poster.png View Binary file 0 comments Download
D android_webview/glue/java/res/drawable-mdpi/icon_webview.png View Binary file 0 comments Download
D android_webview/glue/java/res/drawable-xhdpi/ic_media_video_poster.png View Binary file 0 comments Download
D android_webview/glue/java/res/drawable-xhdpi/icon_webview.png View Binary file 0 comments Download
D android_webview/glue/java/res/drawable-xxhdpi/icon_webview.png View Binary file 0 comments Download

Messages

Total messages: 13 (6 generated)
mkosiba (inactive)
6 years ago (2014-12-11 18:24:38 UTC) #2
Torne
lgtm
6 years ago (2014-12-11 18:56:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802453002/1
6 years ago (2014-12-11 19:34:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802453002/1
6 years ago (2014-12-12 10:27:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802453002/1
6 years ago (2014-12-12 13:31:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 14:39:09 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-12 14:40:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bd10c6a723dba5ea1b5e308540a558147f42f82
Cr-Commit-Position: refs/heads/master@{#308074}

Powered by Google App Engine
This is Rietveld 408576698