Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 802433003: Remove cc::SharedBitmap::memory() (Closed)

Created:
6 years ago by jbauman
Modified:
6 years ago
Reviewers:
piman
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@nogetbitmapfor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove cc::SharedBitmap::memory() This method is only used with the WebPluginDelegateProxy in the renderer, so only support it on a subclass that can be created by the ChildSharedBitmapManager. This will allow us more flexibility in how we implement SharedBitmaps in the future. Committed: https://crrev.com/2b6a74f89bad99e2102f90674f091e2ca2687fc4 Cr-Commit-Position: refs/heads/master@{#308048}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -52 lines) Patch
M cc/resources/shared_bitmap.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M cc/resources/shared_bitmap_manager.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/test_shared_bitmap_manager.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M cc/test/test_shared_bitmap_manager.cc View 1 2 chunks +2 lines, -17 lines 0 comments Download
M content/child/child_shared_bitmap_manager.h View 2 chunks +14 lines, -0 lines 0 comments Download
M content/child/child_shared_bitmap_manager.cc View 3 chunks +19 lines, -13 lines 0 comments Download
M content/common/host_shared_bitmap_manager.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.h View 4 chunks +5 lines, -7 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbauman
6 years ago (2014-12-12 02:50:05 UTC) #2
piman
lgtm
6 years ago (2014-12-12 02:56:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802433003/40001
6 years ago (2014-12-12 02:58:16 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-12 03:50:06 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-12 03:50:42 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2b6a74f89bad99e2102f90674f091e2ca2687fc4
Cr-Commit-Position: refs/heads/master@{#308048}

Powered by Google App Engine
This is Rietveld 408576698