Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 802413003: Standardize usage of virtual/override/final specifiers in google_apis/. (Closed)

Created:
6 years ago by dcheng
Modified:
6 years ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final specifiers in google_apis/. The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 TBR=rogerta@chromoium.org Committed: https://crrev.com/00742d0a34d5aae0f59baedc1173702f22d2aeae Cr-Commit-Position: refs/heads/master@{#309513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -32 lines) Patch
M google_apis/drive/base_requests_server_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/base_requests_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/gdata_wapi_requests_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/account_tracker_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth2_token_service_request_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/ubertoken_fetcher_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M google_apis/gcm/base/mcs_message_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/gcm/base/socket_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/checkin_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/connection_factory_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/connection_handler_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/gservices_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/heartbeat_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/registration_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/unregistration_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/google_api_keys_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dcheng
Dmitry, mind taking a look? It looks like some of the other OWNERS aren't available ...
6 years ago (2014-12-22 22:04:10 UTC) #2
dcheng
+dewittj
6 years ago (2014-12-23 00:34:46 UTC) #4
dewittj
lgtm
6 years ago (2014-12-23 00:59:59 UTC) #5
dcheng
TBRing rogerta
6 years ago (2014-12-23 01:21:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802413003/1
6 years ago (2014-12-23 01:22:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-23 01:34:37 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-23 01:35:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00742d0a34d5aae0f59baedc1173702f22d2aeae
Cr-Commit-Position: refs/heads/master@{#309513}

Powered by Google App Engine
This is Rietveld 408576698