Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: tests/presubmit_unittest.py

Issue 802403003: presubmit_unittest: Fix pylint errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/presubmit_unittest.py
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index fdd801e2b8ee1518b3ec71b334652f37962891a7..3bb79b5c0997c9a3232f106ac9f4664789af6624 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -2000,7 +2000,7 @@ class CannedChecksUnittest(PresubmitTestsBase):
if use_source_file:
input_api1.AffectedSourceFiles(None).AndReturn(files1)
else:
- input_api1.AffectedFiles(include_deleted=False).AndReturn(files1)
+ input_api1.AffectedFiles(include_deletes=False).AndReturn(files1)
presubmit.scm.SVN.GetFileProperty(
presubmit.normpath('foo/bar.cc'), property_name, self.fake_root_dir
).AndReturn(value1)
@@ -2017,7 +2017,7 @@ class CannedChecksUnittest(PresubmitTestsBase):
if use_source_file:
input_api2.AffectedSourceFiles(None).AndReturn(files2)
else:
- input_api2.AffectedFiles(include_deleted=False).AndReturn(files2)
+ input_api2.AffectedFiles(include_deletes=False).AndReturn(files2)
presubmit.scm.SVN.GetFileProperty(
presubmit.normpath('foo/bar.cc'), property_name, self.fake_root_dir
@@ -2175,7 +2175,7 @@ class CannedChecksUnittest(PresubmitTestsBase):
affected_files = (affected_file1, affected_file2,
affected_file3, affected_file4)
- def test(file_filter, include_deletes):
+ def test(include_dirs=False, include_deletes=True, file_filter=None):
self.assertFalse(include_deletes)
for x in affected_files:
if file_filter(x):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698