Issue 802393002: Push API: rename to endpoint and registrationId. [3/3]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 802393002: Push API: rename to endpoint and registrationId. [3/3] (Closed)

Created:
6 years ago by Michael van Ouwerkerk

Modified:
6 years ago

Reviewers:
Peter Beverloo

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@PushRenameRegistrationAttributes

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Push API: rename to endpoint and registrationId. [3/3] This is part of a series: [1] https://codereview.chromium.org/805863002/ [2] https://codereview.chromium.org/795153003/ [3] This CL BUG=442343 Committed: https://crrev.com/c1943d3748e130f7ec21bc2ccbe872d480cdcf3a Cr-Commit-Position: refs/heads/master@{#308589}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	chrome/test/data/push_messaging/push_test.js	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Total messages: 7 (2 generated)

Peter Beverloo

On 2014/12/15 16:59:02, Michael van Ouwerkerk wrote: > Peter, could you take a look please? ...

6 years ago (2014-12-15 17:01:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802393002/20001

6 years ago (2014-12-16 14:20:42 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-16 15:20:11 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/c1943d3748e130f7ec21bc2ccbe872d480cdcf3a
Cr-Commit-Position: refs/heads/master@{#308589}