Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 802383003: Run CSSOM smooth scroll animations on the compositor when possible (Closed)

Created:
5 years, 11 months ago by ajuma
Modified:
5 years, 11 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews, shans, eae+blinkwatch, Steve Block, rwlbuis, pdr+graphicswatchlist_chromium.org, danakj, dstockwell, Timothy Loh, Rik, jchaffraix+rendering, Eric Willigers, rjwright, zoltan1, jbroman, Dominik Röttsches, krit, darktears, blink-reviews-rendering, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, blink-layers+watch_chromium.org, Mike Lawther (Google), f(malita), Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Run CSSOM smooth scroll animations on the compositor when possible This runs smooth scroll animations on the compositor when a composited layer for scrolling already exists and main-thread scrolling isn't required. This also adds a virtual test suite that runs the fast/scroll-behavior tests with --enable-threaded-compositing and --enable-prefer-compositing-to-lcd-text. Smooth scrolling is behind a runtime flag. BUG=243871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188634

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix Windows build #

Total comments: 2

Patch Set 4 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -28 lines) Patch
M LayoutTests/VirtualTestSuites View 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/resources/scroll-behavior-test.js View 2 chunks +7 lines, -2 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/resources/scroll-interruption-test.js View 1 2 chunks +9 lines, -1 line 0 comments Download
A LayoutTests/virtual/threaded/fast/scroll-behavior/README.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/platform/scroll/ProgrammaticScrollAnimator.h View 1 chunk +26 lines, -1 line 0 comments Download
M Source/platform/scroll/ProgrammaticScrollAnimator.cpp View 1 2 3 4 chunks +121 lines, -14 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.h View 2 chunks +4 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollableArea.cpp View 2 chunks +20 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ajuma
5 years, 11 months ago (2015-01-16 20:10:17 UTC) #2
Ian Vollick
Looks great. lgtm. https://codereview.chromium.org/802383003/diff/40001/Source/platform/scroll/ProgrammaticScrollAnimator.cpp File Source/platform/scroll/ProgrammaticScrollAnimator.cpp (right): https://codereview.chromium.org/802383003/diff/40001/Source/platform/scroll/ProgrammaticScrollAnimator.cpp#newcode125 Source/platform/scroll/ProgrammaticScrollAnimator.cpp:125: layer->removeAnimation(m_compositorAnimationId); It took me a moment ...
5 years, 11 months ago (2015-01-17 15:17:42 UTC) #3
ajuma
https://codereview.chromium.org/802383003/diff/40001/Source/platform/scroll/ProgrammaticScrollAnimator.cpp File Source/platform/scroll/ProgrammaticScrollAnimator.cpp (right): https://codereview.chromium.org/802383003/diff/40001/Source/platform/scroll/ProgrammaticScrollAnimator.cpp#newcode125 Source/platform/scroll/ProgrammaticScrollAnimator.cpp:125: layer->removeAnimation(m_compositorAnimationId); On 2015/01/17 15:17:41, vollick wrote: > It took ...
5 years, 11 months ago (2015-01-19 14:22:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802383003/60001
5 years, 11 months ago (2015-01-19 14:23:03 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 15:47:24 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188634

Powered by Google App Engine
This is Rietveld 408576698