Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 802363002: Take the build level into account for the version hash (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
Reviewers:
mvstanton, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Take the build level into account for the version hash build is the third number of the V8 version, and very likely to change (in contrast to the patch level which typically is zero on canaries). BUG=chromium:440984 R=mvstanton@chromium.org,yangguo@chromium.org LOG=n Committed: https://crrev.com/a8045635cbe632cd0e4689e3d150325dd44a5b74 Cr-Commit-Position: refs/heads/master@{#25820}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/version.h View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-12-15 13:50:57 UTC) #1
mvstanton
lgtm
6 years ago (2014-12-15 13:52:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802363002/20001
6 years ago (2014-12-15 13:56:05 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-15 14:28:31 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-17 10:13:26 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8045635cbe632cd0e4689e3d150325dd44a5b74
Cr-Commit-Position: refs/heads/master@{#25820}

Powered by Google App Engine
This is Rietveld 408576698