Issue 802363002: Take the build level into account for the version hash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 802363002: Take the build level into account for the version hash (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)

Modified:
6 years ago

Reviewers:
mvstanton, Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Take the build level into account for the version hash build is the third number of the V8 version, and very likely to change (in contrast to the patch level which typically is zero on canaries). BUG=chromium:440984 R=mvstanton@chromium.org,yangguo@chromium.org LOG=n Committed: https://crrev.com/a8045635cbe632cd0e4689e3d150325dd44a5b74 Cr-Commit-Position: refs/heads/master@{#25820}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/version.h	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802363002/20001

6 years ago (2014-12-15 13:56:05 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-17 10:13:26 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/a8045635cbe632cd0e4689e3d150325dd44a5b74
Cr-Commit-Position: refs/heads/master@{#25820}