Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 802353003: [turbofan] Cache conversions inserted during typed lowering. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Cache conversions inserted during typed lowering. This greatly reduces the number of nodes in the graph (by more than 20x in some extreme cases) for the Emscripten python interpreter main function. BUG=v8:3763 LOG=y TEST=cctest,mjsunit,unittests R=svenpanne@chromium.org Committed: https://crrev.com/2b4eb88cdd490361f29e7971a20c64da29372581 Cr-Commit-Position: refs/heads/master@{#25840}

Patch Set 1 #

Patch Set 2 : Use temp zone. Add missing ToNumber conversion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -77 lines) Patch
M src/compiler/js-typed-lowering.h View 1 3 chunks +8 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 9 chunks +102 lines, -70 lines 0 comments Download
M src/compiler/pipeline.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
6 years ago (2014-12-16 12:13:08 UTC) #1
Benedikt Meurer
PTAL
6 years ago (2014-12-16 12:13:38 UTC) #2
Sven Panne
lgtm
6 years ago (2014-12-16 12:46:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802353003/20001
6 years ago (2014-12-16 12:47:27 UTC) #5
Benedikt Meurer
Committed patchset #2 (id:20001) manually as 2b4eb88cdd490361f29e7971a20c64da29372581 (presubmit successful).
6 years ago (2014-12-16 12:59:24 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-17 10:14:09 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2b4eb88cdd490361f29e7971a20c64da29372581
Cr-Commit-Position: refs/heads/master@{#25840}

Powered by Google App Engine
This is Rietveld 408576698