Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 802343007: cc: Turn off verify_property_trees (Closed)

Created:
6 years ago by hendrikw
Modified:
6 years ago
Reviewers:
Ian Vollick, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Turn off verify_property_trees LayerSorterMainTest.LayerSorterRubik, and possibly other cc_perftests are failing in LayerTreeHostCommon::CalculateDrawProperties, the difference in width and height of visible_content_rect() and visible_rect_from_property_trees() is 2, and the tolerance is 1. CHECK(!failed) is hit. Until the issue is resolved, set verify_property_trees to false BUG=444219 Committed: https://crrev.com/3c8dfa2e9b6c3112dc38cd94e7fef60c38fd173d Cr-Commit-Position: refs/heads/master@{#309468}

Patch Set 1 #

Patch Set 2 : target a single test #

Patch Set 3 : fix comment #

Patch Set 4 : clobber and set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M cc/test/layer_tree_test.h View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_common_perftest.cc View 1 2 3 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
hendrikw
PTAL, thanks!
6 years ago (2014-12-19 23:55:06 UTC) #2
enne (OOO)
LayerTreeTest involves a lot of tests. Can you be more targeted?
6 years ago (2014-12-19 23:56:55 UTC) #3
hendrikw
On 2014/12/19 23:56:55, enne wrote: > LayerTreeTest involves a lot of tests. Can you be ...
6 years ago (2014-12-22 19:07:42 UTC) #4
enne (OOO)
So many boolean parameters. What about just clobbering the setting back to false in LayerTreeHost(Common)PerfTest::InitializeSettings?
6 years ago (2014-12-22 19:11:50 UTC) #5
hendrikw
On 2014/12/22 19:11:50, enne wrote: > So many boolean parameters. What about just clobbering the ...
6 years ago (2014-12-22 19:28:53 UTC) #6
enne (OOO)
lgtm
6 years ago (2014-12-22 19:39:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802343007/60001
6 years ago (2014-12-22 19:49:25 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-22 21:52:56 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-22 21:53:47 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3c8dfa2e9b6c3112dc38cd94e7fef60c38fd173d
Cr-Commit-Position: refs/heads/master@{#309468}

Powered by Google App Engine
This is Rietveld 408576698