Upstream DocumentTabModelImpl and related classes

chrome/android/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/android/rules.gni")
 import("//build/module_args/v8.gni")
 import("//chrome/version.gni")
 import("//third_party/icu/config.gni")
 import("channel.gni")
@@ skipping 71 matching lines @@
     "//components/bookmarks/common/android:bookmarks_java",
     "//components/dom_distiller/android:dom_distiller_core_java",
     "//components/gcm_driver/android:gcm_driver_java",
     "//components/invalidation:java",
     "//components/navigation_interception/android:navigation_interception_java",
     "//components/variations/android:variations_java",
     "//components/web_contents_delegate_android:web_contents_delegate_android_java",
     "//content/public/android:content_java",
     "//printing:printing_java",
     "//sync/android:sync_java",
+    "//third_party/android_protobuf:protobuf_nano_javalib",

[Nico, 2014/12/16 19:52:29]

This doesn't look right to me; the gyp version doesn't need this and
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/andro...
tries to add this automatically where needed from what i understand (?)

[gone, 2014/12/16 19:59:00]

Tried to do it without this line, but PS2 failed the GN bots :/

[cjhopman, 2014/12/16 21:34:00]

In GN, the classpath for a java/android library only contains the things
explicitly listed as dependencies (in gyp it contains all transitive java
dependencies).

The linked template is just for proto_java_library targets.

[cjhopman, 2014/12/16 21:34:00]

Also, GN will probably change to use "all" transitive dependencies for the
classpath since there are some difficult issues with only using direct
dependencies (though this is not necessarily one of those cases).

     "//third_party/android_tools:android_support_v13_java",
     "//third_party/android_tools:android_support_v7_appcompat_java",
     "//third_party/cacheinvalidation:cacheinvalidation_javalib",
     "//third_party/cacheinvalidation:cacheinvalidation_proto_java",
     "//third_party/jsr-305:jsr_305_javalib",
     "//third_party/libaddressinput:android_addressinput_widget_java",
     "//third_party/libaddressinput:android_addressinput_widget_resources",
     "//ui/android:ui_java",
     "//ui/android:ui_java_resources",
   ]
@@ skipping 408 matching lines @@
   ]
 }
 
 zip("chrome_version_srcjar") {
   inputs = [
     chrome_version_java_file,
   ]
   output = "$target_gen_dir/$target_name.srcjar"
   base_dir = chrome_version_java_dir
 }