Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 802343002: Add ability to copy unscaled output pixels. (Closed)

Created:
6 years ago by eustas
Modified:
6 years ago
Reviewers:
no sievers, jbauman
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ability to copy unscaled output pixels. BUG=427418 Committed: https://crrev.com/fd59a531f36586b651f5550c66027d845092a9cf Cr-Commit-Position: refs/heads/master@{#309542}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -15 lines) Patch
M content/browser/compositor/delegated_frame_host.cc View 1 2 3 chunks +10 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 5 chunks +29 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
eustas
6 years ago (2014-12-15 13:12:45 UTC) #2
eustas
jbauman@chromium.org: Please review changes in compositor/
6 years ago (2014-12-15 13:39:09 UTC) #4
eustas
asvitkine@chromium.org: Please review changes in renderer_host/
6 years ago (2014-12-15 13:40:01 UTC) #6
dgozman
Implementation looks fine, but you should update comment render_widget_host_view_base.h.
6 years ago (2014-12-15 16:49:58 UTC) #7
eustas
On 2014/12/15 16:49:58, dgozman wrote: > Implementation looks fine, but you should update comment > ...
6 years ago (2014-12-15 17:17:34 UTC) #8
eustas
6 years ago (2014-12-16 05:53:58 UTC) #11
jbauman
lgtm
6 years ago (2014-12-16 05:55:42 UTC) #12
eustas
Hello, Daniel. Could you take a look at renderer_host/, please. Thank you.
6 years ago (2014-12-18 14:22:46 UTC) #15
no sievers
https://codereview.chromium.org/802343002/diff/20001/content/browser/renderer_host/render_widget_host_view_android.cc File content/browser/renderer_host/render_widget_host_view_android.cc (right): https://codereview.chromium.org/802343002/diff/20001/content/browser/renderer_host/render_widget_host_view_android.cc#newcode1288 content/browser/renderer_host/render_widget_host_view_android.cc:1288: output_size_in_pixel = src_subrect_in_pixel.size(); So we don't handle |src_subrect_in_pixel| being ...
6 years ago (2014-12-18 19:23:21 UTC) #16
eustas
https://codereview.chromium.org/802343002/diff/20001/content/browser/renderer_host/render_widget_host_view_android.cc File content/browser/renderer_host/render_widget_host_view_android.cc (right): https://codereview.chromium.org/802343002/diff/20001/content/browser/renderer_host/render_widget_host_view_android.cc#newcode1288 content/browser/renderer_host/render_widget_host_view_android.cc:1288: output_size_in_pixel = src_subrect_in_pixel.size(); On 2014/12/18 19:23:20, sievers wrote: > ...
6 years ago (2014-12-18 19:59:17 UTC) #17
eustas
PTAL
6 years ago (2014-12-19 09:51:48 UTC) #18
eustas
Ping
6 years ago (2014-12-22 08:31:02 UTC) #19
no sievers
lgtm
6 years ago (2014-12-22 18:18:22 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802343002/40001
6 years ago (2014-12-23 05:34:09 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-23 07:13:34 UTC) #23
commit-bot: I haz the power
6 years ago (2014-12-23 07:14:20 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fd59a531f36586b651f5550c66027d845092a9cf
Cr-Commit-Position: refs/heads/master@{#309542}

Powered by Google App Engine
This is Rietveld 408576698