Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 802323005: Revert of Validate Bucket data in ShaderSourceBucket. (Closed)

Created:
5 years, 11 months ago by sivag
Modified:
5 years, 11 months ago
CC:
chromium-reviews, piman+watch_chromium.org, Thanik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Validate Bucket data in ShaderSourceBucket. (patchset #6 id:100001 of https://codereview.chromium.org/822953002/) Reason for revert: No need to check for memory allocation failure. New never returns NULL. In Chrome we explicitly abort (crash) before returning from the allocator in case of allocation failure. Original issue's description: > Validate Bucket data in ShaderSourceBucket. > > As of now only the received bucket and > the size of bucket are validated. We > should check for validation of bucket > data before we start using it and report > failures. > > BUG=240467 > > Committed: https://crrev.com/6df438ed2adaf24fa2f4a92d4f3863825247b910 > Cr-Commit-Position: refs/heads/master@{#309882} TBR=sievers@chromium.org,piman@chromium.org,bajones@chromium.org,zmo@chromium.org NOTREECHECKS=true NOTRY=true BUG=240467 Committed: https://crrev.com/67d1a03057042dfc9bb0a71f9906320ee5204301 Cr-Commit-Position: refs/heads/master@{#310078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M gpu/command_buffer/service/common_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/common_decoder.cc View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sivag
Created Revert of Validate Bucket data in ShaderSourceBucket.
5 years, 11 months ago (2015-01-06 11:09:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802323005/1
5 years, 11 months ago (2015-01-06 11:11:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 11:11:51 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 11:12:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67d1a03057042dfc9bb0a71f9906320ee5204301
Cr-Commit-Position: refs/heads/master@{#310078}

Powered by Google App Engine
This is Rietveld 408576698