src/parser.cc - Issue 802313003: RegExpParser: Fix Reset()ting to the end.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 802313003: RegExpParser: Fix Reset()ting to the end. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: long lines Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index 9cb92b3c535e79900d1782c689ac0966cef1d15b..0713b26e8b9bfb24e9c06ad5c1500754d7243ab1 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -4323,6 +4323,9 @@ void RegExpParser::Advance() {

}

} else {

current_ = kEndMarker;

+ // Advance so that position() points to 1-after-the-last-character. This is

+ // important so that Reset() to this position works correctly.

+ next_pos_ = in()->length() + 1;

has_more_ = false;

}

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-3756.js » ('j') | no next file with comments »