Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: components/password_manager/content/browser/content_credential_manager_dispatcher.h

Issue 802303002: Credential Manager: Switch 'request()' to GetAutofillableLogins(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ScopedVector Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/content/browser/content_credential_manager_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/content/browser/content_credential_manager_dispatcher.h
diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher.h b/components/password_manager/content/browser/content_credential_manager_dispatcher.h
index 5ed9df03bf61632f1a39fb6dda7e92e0f1768d18..9d46eacb68b10912fe0f8e7c06050504d7ffccfb 100644
--- a/components/password_manager/content/browser/content_credential_manager_dispatcher.h
+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher.h
@@ -7,6 +7,7 @@
#include "base/callback.h"
#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "components/password_manager/core/browser/credential_manager_dispatcher.h"
#include "components/password_manager/core/browser/password_store_consumer.h"
@@ -61,6 +62,8 @@ class ContentCredentialManagerDispatcher : public CredentialManagerDispatcher,
base::Callback<void(const autofill::PasswordForm&)>;
private:
+ struct PendingRequestParameters;
+
PasswordStore* GetPasswordStore();
// Returns the driver for the current main frame.
@@ -73,9 +76,9 @@ class ContentCredentialManagerDispatcher : public CredentialManagerDispatcher,
scoped_ptr<CredentialManagerPasswordFormManager> form_manager_;
// When 'OnRequestCredential' is called, it in turn calls out to the
- // PasswordStore; we store the request ID here in order to properly respond
- // to the request once the PasswordStore gives us data.
- int pending_request_id_;
+ // PasswordStore; we store request details here in order to properly
+ // respond to the request once the PasswordStore gives us data.
+ scoped_ptr<PendingRequestParameters> pending_request_;
DISALLOW_COPY_AND_ASSIGN(ContentCredentialManagerDispatcher);
};
« no previous file with comments | « no previous file | components/password_manager/content/browser/content_credential_manager_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698