Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 802293002: Revert of Stub for web-base client for DevTools bridge and tests (Closed)

Created:
6 years ago by SeRya
Modified:
6 years ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Stub for web-base client for DevTools bridge and tests (patchset #5 id:100001 of https://codereview.chromium.org/736363002/) Reason for revert: Reverting since now DevToolsBridgeClient (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/devtools/device/webrtc/devtools_bridge_client.h) is that WebClient supposed to be. All further code will be placed there. Original issue's description: > Stub for web-base client for DevTools bridge and tests > > This patch mostly consists of testing environment for web WebClient. While > WebClient intended to be base for a new DeviceProvider in DevTools frontend > (https://codereview.chromium.org/720133002/) it is convinient to run > tests on android. It lets to test the client directly against server > counterpart avoiding flakiness of network and cloud services. > > TBR=jochen@chromium.org > BUG=383418 > > Committed: https://crrev.com/ff7a801dfddaa22643accaf3e0df192470fb7a7b > Cr-Commit-Position: refs/heads/master@{#305131} TBR=mnaganov@chromium.org,dgozman@chromium.org NOTREECHECKS=true NOTRY=true BUG=383418 Committed: https://crrev.com/e4584d5cb7327be5e2d76752855757a9e0c2785e Cr-Commit-Position: refs/heads/master@{#308329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -497 lines) Patch
M build/all.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M components/devtools_bridge.gyp View 5 chunks +14 lines, -106 lines 0 comments Download
M components/devtools_bridge/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
D components/devtools_bridge/android/client/javatests/AndroidManifest.xml View 1 chunk +0 lines, -36 lines 0 comments Download
D components/devtools_bridge/android/client/javatests/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/devtools_bridge/android/client/javatests/src/org/chromium/components/devtools_bridge/WebClientTest.java View 1 chunk +0 lines, -43 lines 0 comments Download
D components/devtools_bridge/android/client/javatests/src/org/chromium/components/devtools_bridge/browsertests/TestApplication.java View 1 chunk +0 lines, -78 lines 0 comments Download
M components/devtools_bridge/android/session_dependency_factory_android.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/devtools_bridge/android/session_dependency_factory_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D components/devtools_bridge/client/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D components/devtools_bridge/client/web_client.h View 1 chunk +0 lines, -46 lines 0 comments Download
D components/devtools_bridge/client/web_client.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D components/devtools_bridge/test/android/client/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/devtools_bridge/test/android/client/javatests/jni/jni_onload.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D components/devtools_bridge/test/android/client/javatests/src/org/chromium/components/devtools_bridge/WebClient.java View 1 chunk +0 lines, -27 lines 0 comments Download
D components/devtools_bridge/test/android/client/web_client_android.h View 1 chunk +0 lines, -34 lines 0 comments Download
D components/devtools_bridge/test/android/client/web_client_android.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M components/devtools_bridge/test/android/javatests/jni/jni_onload.cc View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
SeRya
Created Revert of Stub for web-base client for DevTools bridge and tests
6 years ago (2014-12-15 09:32:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802293002/1
6 years ago (2014-12-15 09:32:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 09:33:33 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-15 09:34:27 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4584d5cb7327be5e2d76752855757a9e0c2785e
Cr-Commit-Position: refs/heads/master@{#308329}

Powered by Google App Engine
This is Rietveld 408576698