Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 802283005: Gallery: Update metadata in GalleryItem when saving items. (Closed)

Created:
5 years, 11 months ago by hirono
Modified:
5 years, 11 months ago
Reviewers:
yawano
CC:
chromium-reviews, nkostylev+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: Obtain metadata from MetadataCache when saving items. Previously, when saving items, the new metadata was generated by GalleryDataModel. But the generated metadata was broken and it contained old thumbnail data that causes memory shortage. The metadata for new items can be otained by using normal code path (MetadataCache), so the CL removes special geneartion of metadata for new items and let Gallery obtain the metadata by using MeatadataCache. BUG=439898 TEST=GalleryJsTest.GalleryItemTest Committed: https://crrev.com/699c53ebb13827f09e6cb5d4564f69da03d58692 Cr-Commit-Position: refs/heads/master@{#310205}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -49 lines) Patch
M chrome/browser/chromeos/file_manager/gallery_jstest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 1 chunk +2 lines, -22 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_item.js View 1 4 chunks +32 lines, -27 lines 0 comments Download
A ui/file_manager/gallery/js/gallery_item_unittest.html View 1 chunk +23 lines, -0 lines 0 comments Download
A ui/file_manager/gallery/js/gallery_item_unittest.js View 1 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
hirono
PTAL the CL? Thanks!
5 years, 11 months ago (2015-01-06 08:11:11 UTC) #4
yawano
Thank you. https://codereview.chromium.org/802283005/diff/40001/ui/file_manager/gallery/js/gallery_item.js File ui/file_manager/gallery/js/gallery_item.js (right): https://codereview.chromium.org/802283005/diff/40001/ui/file_manager/gallery/js/gallery_item.js#newcode251 ui/file_manager/gallery/js/gallery_item.js:251: this.metadataCache_.clear([this.entry_], 'fetchedMedia'); Since the file is changed ...
5 years, 11 months ago (2015-01-06 08:40:02 UTC) #5
hirono
https://codereview.chromium.org/802283005/diff/40001/ui/file_manager/gallery/js/gallery_item.js File ui/file_manager/gallery/js/gallery_item.js (right): https://codereview.chromium.org/802283005/diff/40001/ui/file_manager/gallery/js/gallery_item.js#newcode251 ui/file_manager/gallery/js/gallery_item.js:251: this.metadataCache_.clear([this.entry_], 'fetchedMedia'); On 2015/01/06 08:40:02, yawano wrote: > Since ...
5 years, 11 months ago (2015-01-06 10:33:57 UTC) #6
yawano
lgtm. Thank you!
5 years, 11 months ago (2015-01-06 10:37:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802283005/60001
5 years, 11 months ago (2015-01-07 01:02:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 11 months ago (2015-01-07 01:17:22 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 01:18:22 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/699c53ebb13827f09e6cb5d4564f69da03d58692
Cr-Commit-Position: refs/heads/master@{#310205}

Powered by Google App Engine
This is Rietveld 408576698