Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 802243004: [arm] Fix sNaN quietening in the ARM simulator on IA-32. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Fix sNaN quietening in the ARM simulator on IA-32. TEST=msjunit/regress/regress-undefined-nan2 R=jkummerow@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/ee86227600e4e923a6c75b28051413594b0900b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -29 lines) Patch
M src/arm/simulator-arm.cc View 5 chunks +15 lines, -24 lines 0 comments Download
A + test/mjsunit/regress/regress-undefined-nan2.js View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-21 12:56:27 UTC) #1
Jakob Kummerow
lgtm
5 years, 11 months ago (2015-01-21 13:00:32 UTC) #2
Benedikt Meurer
Committed patchset #1 (id:1) manually as ee86227600e4e923a6c75b28051413594b0900b4 (tree was closed).
5 years, 11 months ago (2015-01-21 13:01:31 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 13:01:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee86227600e4e923a6c75b28051413594b0900b4
Cr-Commit-Position: refs/heads/master@{#26185}

Powered by Google App Engine
This is Rietveld 408576698