Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: Source/core/rendering/RenderGrid.cpp

Issue 802243003: [CSS Grid Layout] Incorrect sizing of tracks with non-spanning items (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderGrid.cpp
diff --git a/Source/core/rendering/RenderGrid.cpp b/Source/core/rendering/RenderGrid.cpp
index 5221e3ece7743c67a854c39e39114332caa1b9f9..f12c15bfc89360eae40e33913086e0a864d20e25 100644
--- a/Source/core/rendering/RenderGrid.cpp
+++ b/Source/core/rendering/RenderGrid.cpp
@@ -736,12 +736,15 @@ void RenderGrid::resolveContentBasedTrackSizingFunctions(GridTrackSizingDirectio
HashSet<RenderBox*> itemsSet;
for (const auto& trackIndex : sizingData.contentSizedTracksIndex) {
GridIterator iterator(m_grid, direction, trackIndex);
+ GridTrack& track = (direction == ForColumns) ? sizingData.columnTracks[trackIndex] : sizingData.rowTracks[trackIndex];
while (RenderBox* gridItem = iterator.nextGridItem()) {
if (itemsSet.add(gridItem).isNewEntry) {
const GridCoordinate& coordinate = cachedGridCoordinate(*gridItem);
- // We should not include items spanning more than one track that span tracks with flexible sizing functions.
- if (integerSpanForDirection(coordinate, direction) == 1 || !spanningItemCrossesFlexibleSizedTracks(coordinate, direction))
+ if (integerSpanForDirection(coordinate, direction) == 1) {
+ resolveContentBasedTrackSizingFunctionsForNonSpanningItems(direction, coordinate, *gridItem, track, sizingData.columnTracks);
+ } else if (!spanningItemCrossesFlexibleSizedTracks(coordinate, direction)) {
sizingData.itemsSortedByIncreasingSpan.append(GridItemWithSpan(*gridItem, coordinate, direction));
+ }
}
}
}
@@ -763,6 +766,22 @@ void RenderGrid::resolveContentBasedTrackSizingFunctions(GridTrackSizingDirectio
}
}
+void RenderGrid::resolveContentBasedTrackSizingFunctionsForNonSpanningItems(GridTrackSizingDirection direction, const GridCoordinate& coordinate, RenderBox& gridItem, GridTrack& track, Vector<GridTrack>& columnTracks)
+{
+ const GridResolvedPosition trackPosition = (direction == ForColumns) ? coordinate.columns.resolvedInitialPosition : coordinate.rows.resolvedInitialPosition;
+ GridTrackSize trackSize = gridTrackSize(direction, trackPosition.toInt());
+
+ if (trackSize.hasMinContentMinTrackBreadth())
+ track.m_usedBreadth = std::max(track.m_usedBreadth, minContentForChild(gridItem, direction, columnTracks));
+ else if (trackSize.hasMaxContentMinTrackBreadth())
+ track.m_usedBreadth = std::max(track.m_usedBreadth, maxContentForChild(gridItem, direction, columnTracks));
+
+ if (trackSize.hasMinContentMaxTrackBreadth())
+ track.m_maxBreadth = std::max(track.m_maxBreadth, minContentForChild(gridItem, direction, columnTracks));
+ else if (trackSize.hasMaxContentMaxTrackBreadth())
+ track.m_maxBreadth = std::max(track.m_maxBreadth, maxContentForChild(gridItem, direction, columnTracks));
+}
+
void RenderGrid::resolveContentBasedTrackSizingFunctionsForItems(GridTrackSizingDirection direction, GridSizingData& sizingData, GridItemWithSpan& gridItemWithSpan, FilterFunction filterFunction, SizingFunction sizingFunction, AccumulatorGetter trackGetter, AccumulatorGrowFunction trackGrowthFunction, FilterFunction growAboveMaxBreadthFilterFunction)
{
const GridCoordinate coordinate = gridItemWithSpan.coordinate();

Powered by Google App Engine
This is Rietveld 408576698