Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 802243002: Revert of Fix file naming issue causing page_run_end_to_end tests to never run (at least when run locally usi… (Closed)

Created:
6 years ago by Andre
Modified:
6 years ago
Reviewers:
nednguyen, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix file naming issue causing page_run_end_to_end tests to never run (at least when run locally usi… (patchset #2 id:20001 of https://codereview.chromium.org/805593002/) Reason for revert: Some of the newly enabled tests fail on the bots. For example, https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/51555 Original issue's description: > Fix file naming issue causing page_run_end_to_end tests to never run (at least when run locally using run_tests script). > Fix a failing test from this file. > > Found this while fixing unit test for max_failures patch > (https://codereview.chromium.org/790673005/). > > BUG=440101 > > Committed: https://crrev.com/c484a63e356fb1011b553b94612586d2084325d3 > Cr-Commit-Position: refs/heads/master@{#308264} TBR=nednguyen@google.com,chrishenry@google.com NOTREECHECKS=true NOTRY=true BUG=440101 Committed: https://crrev.com/31c73158c92164fc92d068f58e55306292130f68 Cr-Commit-Position: refs/heads/master@{#308313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -485 lines) Patch
A tools/telemetry/telemetry/page/page_run_end_to_end_tests.py View 1 chunk +485 lines, -0 lines 0 comments Download
D tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py View 1 chunk +0 lines, -485 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Andre
6 years ago (2014-12-15 04:54:50 UTC) #1
Created Revert of Fix file naming issue causing page_run_end_to_end tests to
never run (at least when run locally usi…

Powered by Google App Engine
This is Rietveld 408576698