Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

Issue 802233004: Implement icon attribute for menuitem (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: LayoutTest rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp b/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
index b34fa9029033d69808873f511a2b120798e60057..93eb1f6bcc9d61e071a0f8a8d39fa1fb2ad6c603 100644
--- a/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
@@ -73,6 +73,7 @@ static bool populateContextMenuItems(const v8::Local<v8::Array>& itemArray, Cont
if (typeString == "separator") {
ContextMenuItem item(ContextMenuItem(SeparatorType,
ContextMenuItemCustomTagNoAction,
+ String(),
String()));
menu.appendItem(item);
} else if (typeString == "subMenu" && subItems->IsArray()) {
@@ -84,12 +85,13 @@ static bool populateContextMenuItems(const v8::Local<v8::Array>& itemArray, Cont
ContextMenuItem item(SubmenuType,
ContextMenuItemCustomTagNoAction,
labelString,
+ String(),
&subMenu);
menu.appendItem(item);
} else {
ContextMenuAction typedId = static_cast<ContextMenuAction>(ContextMenuItemBaseCustomTag + id->ToInt32(isolate)->Value());
TOSTRING_DEFAULT(V8StringResource<TreatNullAsNullString>, labelString, label, false);
- ContextMenuItem menuItem((typeString == "checkbox" ? CheckableActionType : ActionType), typedId, labelString);
+ ContextMenuItem menuItem((typeString == "checkbox" ? CheckableActionType : ActionType), typedId, labelString, String());
if (checked->IsBoolean())
menuItem.setChecked(checked->ToBoolean(isolate)->Value());
if (enabled->IsBoolean())
« no previous file with comments | « LayoutTests/webexposed/element-instance-property-listing-expected.txt ('k') | Source/core/html/HTMLAttributeNames.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698