Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(21)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: Source/core/html/HTMLAttributeNames.in
Issue
802233004
:
Implement icon attribute for menuitem (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: LayoutTest rebase
Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/http/tests/misc/custom-context-menu.html
LayoutTests/http/tests/misc/custom-context-menu-expected.txt
LayoutTests/webexposed/element-instance-property-listing-expected.txt
Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
Source/core/html/HTMLAttributeNames.in
Source/core/html/HTMLMenuItemElement.idl
Source/core/page/CustomContextMenuProvider.cpp
Source/platform/ContextMenuItem.h
Source/platform/ContextMenuItem.cpp
Source/web/ContextMenuClientImpl.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
('k') |
Source/core/html/HTMLMenuItemElement.idl »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 namespace="HTML"
1 namespace="HTML"
2 namespacePrefix="xhtml"
2 namespacePrefix="xhtml"
3 namespaceURI="http://www.w3.org/1999/xhtml"
3 namespaceURI="http://www.w3.org/1999/xhtml"
4 attrsNullNamespace
4 attrsNullNamespace
5
5
6 abbr
6 abbr
7 accept-charset
7 accept-charset
8 accept
8 accept
9 accesskey
9 accesskey
10 action
10 action
(...skipping
97
matching lines...)
Expand 10 before
|
Expand all
|
Expand 10 after
Loading...
108 frame
108 frame
109 frameborder
109 frameborder
110 headers
110 headers
111 height
111 height
112 hidden
112 hidden
113 high
113 high
114 href
114 href
115 hreflang
115 hreflang
116 hspace
116 hspace
117 http-equiv
117 http-equiv
118
icon
118 id
119 id
119 incremental
120 incremental
120 inputmode
121 inputmode
121 integrity
122 integrity
122 is
123 is
123 ismap
124 ismap
124 keytype
125 keytype
125 kind
126 kind
126 label
127 label
127 lang
128 lang
(...skipping
177
matching lines...)
Expand 10 before
|
Expand all
|
Expand 10 after
Loading...
305 usemap
306 usemap
306 valign
307 valign
307 value
308 value
308 valuetype
309 valuetype
309 version
310 version
310 vlink
311 vlink
311 vspace
312 vspace
312 webkitdirectory
313 webkitdirectory
313 width
314 width
314 wrap
315 wrap
OLD
NEW
« no previous file with comments
|
« Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
('k') |
Source/core/html/HTMLMenuItemElement.idl »
('j') |
no next file with comments »
Issue 802233004: Implement icon attribute for menuitem (Closed)
Created 6 years ago by pals
Modified 5 years, 10 months ago
Reviewers: chrishtr, haraken, keishi
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 2
This is Rietveld
408576698
Chromium Code Reviews
Issue 802233004:
Implement icon attribute for menuitem (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master