Issue 80223003: Show basic SkPicture details in debugger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 80223003: Show basic SkPicture details in debugger. (Closed)

Created:
7 years, 1 month ago by f(malita)

Modified:
7 years, 1 month ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Show basic SkPicture details in debugger. R=robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=12345

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	src/utils/debugger/SkDrawCommand.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/utils/debugger/SkDrawCommand.cpp	View		1 chunk	+17 lines, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm https://codereview.chromium.org/80223003/diff/1/src/utils/debugger/SkDrawCommand.cpp File src/utils/debugger/SkDrawCommand.cpp (right): https://codereview.chromium.org/80223003/diff/1/src/utils/debugger/SkDrawCommand.cpp#newcode503 src/utils/debugger/SkDrawCommand.cpp:503: drawPicture should take a const SkPicture :(

7 years, 1 month ago (2013-11-21 16:46:37 UTC) #2

f(malita)

On 2013/11/21 16:46:37, robertphillips wrote: > lgtm > > https://codereview.chromium.org/80223003/diff/1/src/utils/debugger/SkDrawCommand.cpp > File src/utils/debugger/SkDrawCommand.cpp (right): > ...

7 years, 1 month ago (2013-11-21 17:06:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/80223003/1

7 years, 1 month ago (2013-11-21 17:07:30 UTC) #4

Message was sent while issue was closed.

Change committed as 12345

Expand Messages | Collapse Messages