Issue 802153004: Reuse the DOM in the <fps-counter>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 802153004: Reuse the DOM in the <fps-counter>. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Reuse the DOM in the <fps-counter>. Instead of storing primitive values which makes the data binding system throw away DOM each time we update each slot lets just use objects and shift + pop. This means very little data binding churn. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1687ef80a52e0ed4589dc2a0f39b3b027bd35cd7

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -21 lines)			Patch
	M	sky/examples/fps-counter.sky	View		3 chunks	+26 lines, -21 lines	0 comments	Download

Total messages: 5 (1 generated)

abarth-chromium

do you want to replace the reduce with something more bit smashy?

5 years, 11 months ago (2015-01-16 05:37:04 UTC) #3

esprehn

5 years, 11 months ago (2015-01-16 06:02:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as
1687ef80a52e0ed4589dc2a0f39b3b027bd35cd7 (presubmit successful).