LayoutTests/svg/animations/resources/animation-policy.svg - Issue 802143002: AnimationPolicy setting is applied to SVG animation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/animations/resources/animation-policy.svg

Issue 802143002: AnimationPolicy setting is applied to SVG animation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update code Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="UTF-8"?>

	2 <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Tiny//EN" "http://www.w3.org/Graphics/ SVG/1.1/DTD/svg11-tiny.dtd">
	fs 2014/12/25 17:32:07 You can drop this. You can drop this. je_julie(Not used) 2014/12/27 07:08:53 Done. Show quoted text On 2014/12/25 17:32:07, fs (OoO) wrote: > You can drop this. Done.
	3 <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlin k">
	fs 2014/12/25 17:32:07 You don't need to declare the xlink namespace. You don't need to declare the xlink namespace. je_julie(Not used) 2014/12/27 07:08:53 Done. Show quoted text On 2014/12/25 17:32:07, fs (OoO) wrote: > You don't need to declare the xlink namespace. Done.
	4

	5 <animate id="an1" attributeName="visibility" to="visible" begin="0s" dur="3s" re peatCount="indefinite"/>
	fs 2014/12/25 17:32:07 What case is this for? (AFAICS this will animate f What case is this for? (AFAICS this will animate from 'visible' to 'visible'.) je_julie(Not used) 2014/12/27 07:08:53 I changed it with y, values="30;50;100" and discre Show quoted text On 2014/12/25 17:32:07, fs (OoO) wrote: > What case is this for? (AFAICS this will animate from 'visible' to 'visible'.) I changed it with y, values="30;50;100" and discrete mode.
	6 <rect x="50" y="0" width="100" height="100" fill="green">

	7 <set id="top" attributeName="y" to="30"

	8 begin="0s; bottom.end" dur="1s" fill="freeze"/>
	fs 2014/12/25 17:32:07 I don't see a need for the 'freeze's here. Could a I don't see a need for the 'freeze's here. Could also just make this a discrete-mode animation w/ values="30;50;100" and a repeat. je_julie(Not used) 2014/12/27 07:08:53 Removed freeze. I removed set tags and I changed a Show quoted text On 2014/12/25 17:32:07, fs (OoO) wrote: > I don't see a need for the 'freeze's here. Could also just make this a > discrete-mode animation w/ values="30;50;100" and a repeat. Removed freeze. I removed set tags and I changed animate tag with discrete. Do I need to keep set tags even if I use discrete mode. fs 2014/12/27 15:36:34 No, this should be fine. Show quoted text On 2014/12/27 07:08:53, je_julie wrote: > On 2014/12/25 17:32:07, fs (OoO) wrote: > > I don't see a need for the 'freeze's here. Could also just make this a > > discrete-mode animation w/ values="30;50;100" and a repeat. > > Removed freeze. > I removed set tags and I changed animate tag with discrete. > Do I need to keep set tags even if I use discrete mode. No, this should be fine.
	9 <set id="middle" attributeName="y" to="50"

	10 begin="top.end" dur="1s" fill="freeze"/>

	11 <set id="bottom" attributeName="y" to="100"
	fs 2014/12/25 17:32:07 Maybe align this with the other two <set>. Maybe align this with the other two <set>. je_julie(Not used) 2014/12/27 07:08:53 Removed set tags. Show quoted text On 2014/12/25 17:32:07, fs (OoO) wrote: > Maybe align this with the other two <set>. Removed set tags.
	12 begin="middle.end" dur="1s" fill="freeze"/>

	13 </rect>

	14 </svg>

OLD	NEW