Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 802123003: Adding LayoutTest for testing XMLHttpRequest.responseXML returns an XMLDocument. (Closed)

Created:
6 years ago by Paritosh Kumar
Modified:
5 years, 11 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Adding LayoutTest for testing XMLHttpRequest.responseXML returns an XMLDocument. BUG=425971 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187847

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
A LayoutTests/http/tests/xmlhttprequest/responsexml-type.html View 1 1 chunk +28 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/responsexml-type-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paritosh Kumar
Please have a look on the added LayoutTest. -Paritosh
6 years ago (2014-12-23 09:45:56 UTC) #2
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/802123003/diff/1/LayoutTests/http/tests/xmlhttprequest/responsexml-type.html File LayoutTests/http/tests/xmlhttprequest/responsexml-type.html (right): https://codereview.chromium.org/802123003/diff/1/LayoutTests/http/tests/xmlhttprequest/responsexml-type.html#newcode28 LayoutTests/http/tests/xmlhttprequest/responsexml-type.html:28: </html> remove https://codereview.chromium.org/802123003/diff/1/LayoutTests/http/tests/xmlhttprequest/responsexml-type.html#newcode30 LayoutTests/http/tests/xmlhttprequest/responsexml-type.html:30: remove these blank lines
5 years, 11 months ago (2015-01-05 05:04:34 UTC) #3
Paritosh Kumar
Thanks https://codereview.chromium.org/802123003/diff/1/LayoutTests/http/tests/xmlhttprequest/responsexml-type.html File LayoutTests/http/tests/xmlhttprequest/responsexml-type.html (right): https://codereview.chromium.org/802123003/diff/1/LayoutTests/http/tests/xmlhttprequest/responsexml-type.html#newcode28 LayoutTests/http/tests/xmlhttprequest/responsexml-type.html:28: </html> On 2015/01/05 05:04:34, tyoshino wrote: > remove ...
5 years, 11 months ago (2015-01-05 05:34:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802123003/20001
5 years, 11 months ago (2015-01-05 05:36:38 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 06:47:33 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187847

Powered by Google App Engine
This is Rietveld 408576698