Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 802103006: Stricter parsing for span attribute on col element (Closed)

Created:
5 years, 11 months ago by rwlbuis
Modified:
5 years, 11 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Stricter parsing for span attribute on col element According to the latest spec "The element may have a span content attribute specified, whose value must be a valid non-negative integer greater than zero." With this patch parsing is more strict and above rules are honored. This was showing as failures here, fixed with this patch: http://w3c-test.org/html/dom/reflection-forms.html Behavior matches Firefox. Spec reference: https://html.spec.whatwg.org/#dom-colgroup-span Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187978

Patch Set 1 #

Patch Set 2 : Add a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -4 lines) Patch
A LayoutTests/fast/dom/HTMLTableColElement/span-attribute.html View 1 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLTableColElement/span-attribute-expected.txt View 1 1 chunk +31 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTableColElement.cpp View 1 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rwlbuis
PTAL. Normally I would ask tkent but I think he is OOO. Feel free to ...
5 years, 11 months ago (2015-01-06 23:48:28 UTC) #2
Hajime Morrita
On 2015/01/06 23:48:28, rwlbuis wrote: > PTAL. Normally I would ask tkent but I think ...
5 years, 11 months ago (2015-01-06 23:58:17 UTC) #3
kouhei (in TOK)
lgtm
5 years, 11 months ago (2015-01-07 05:51:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802103006/20001
5 years, 11 months ago (2015-01-07 15:11:00 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 16:26:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187978

Powered by Google App Engine
This is Rietveld 408576698