Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3448)

Unified Diff: base/message_pump_x.cc

Issue 8021009: Consolidate message observer API for win and aura (and touch). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/message_pump_x.cc
diff --git a/base/message_pump_x.cc b/base/message_pump_x.cc
index f9a2b6f989924b5bf9182c93c2e8af6b497e0154..9f8776e07e3b990cdc0922a5b2dbc177799009f1 100644
--- a/base/message_pump_x.cc
+++ b/base/message_pump_x.cc
@@ -180,7 +180,7 @@ bool MessagePumpX::ProcessXEvent(XEvent* xev) {
have_cookie = true;
}
- if (WillProcessXEvent(xev) == MessagePumpObserver::EVENT_CONTINUE) {
+ if (WillProcessXEvent(xev) == EVENT_CONTINUE) {
MessagePumpDispatcher::DispatchStatus status =
GetDispatcher()->Dispatch(xev);
@@ -190,6 +190,7 @@ bool MessagePumpX::ProcessXEvent(XEvent* xev) {
} else if (status == MessagePumpDispatcher::EVENT_IGNORED) {
VLOG(1) << "Event (" << xev->type << ") not handled.";
}
+ DidProcessXEvent(xev);
}
if (have_cookie) {
@@ -251,12 +252,20 @@ bool MessagePumpX::WillProcessXEvent(XEvent* xevent) {
ObserverListBase<MessagePumpObserver>::Iterator it(observers());
MessagePumpObserver* obs;
while ((obs = it.GetNext()) != NULL) {
- if (obs->WillProcessXEvent(xevent))
+ if (obs->WillProcessEvent(xevent))
return true;
}
return false;
}
+void MessagePumpX::DidProcessXEvent(XEvent* xevent) {
+ ObserverListBase<MessagePumpObserver>::Iterator it(observers());
+ MessagePumpObserver* obs;
+ while ((obs = it.GetNext()) != NULL) {
+ obs->DidProcessEvent(xevent);
+ }
+}
+
#if defined(TOOLKIT_USES_GTK)
GdkFilterReturn MessagePumpX::GdkEventFilter(GdkXEvent* gxevent,
GdkEvent* gevent,
@@ -315,9 +324,4 @@ COMPILE_ASSERT(XLASTEvent >= LASTEvent, XLASTEvent_too_small);
#endif // defined(TOOLKIT_USES_GTK)
-MessagePumpObserver::EventStatus
- MessagePumpObserver::WillProcessXEvent(XEvent* xev) {
- return EVENT_CONTINUE;
-}
-
} // namespace base

Powered by Google App Engine
This is Rietveld 408576698