Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 802003003: Subzero: Clean up live range construction. (Closed)

Created:
6 years ago by Jim Stichnoth
Modified:
6 years ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Clean up live range construction. Moves the deletion of newly dead instructions into the main liveness() routine. The old livenessPostProcess() routine is renamed and now used purely for live range construction. The hack is removed in which live in-args have a custom live range segment added to avoid an artifact of the live ranges. It is replaced with a gentler hack that extends the instruction numbering range of the initial basic block to avoid the artifact. Since special live range segments no longer need to be prepended, the live range representation is simplified and we can always assume that segments are being appended, never prepended (and as before, never added to the middle). Some magic constants involving special instruction numbers are replaced with symbolic constants. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e5b73e6e3aa4e9f9819494d34662f3f6d928b078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -87 lines) Patch
M src/IceCfg.cpp View 4 chunks +41 lines, -34 lines 0 comments Download
M src/IceCfgNode.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/IceCfgNode.cpp View 1 chunk +7 lines, -31 lines 0 comments Download
M src/IceInst.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/IceOperand.cpp View 1 chunk +8 lines, -19 lines 0 comments Download
M src/IceTimerTree.def View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
6 years ago (2014-12-13 01:06:35 UTC) #2
jvoung (off chromium)
LGTM
6 years ago (2014-12-15 16:49:46 UTC) #3
Jim Stichnoth
6 years ago (2014-12-15 17:58:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e5b73e6e3aa4e9f9819494d34662f3f6d928b078 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698