Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(613)

Issue 8020006: Merge 95668 - [chromium] SharedGraphicsContext3D's context should not be destroyed during atexit (Closed)

Created:
8 years, 4 months ago by jamesr
Modified:
8 years, 4 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 95668 - [chromium] SharedGraphicsContext3D's context should not be destroyed during atexit https://bugs.webkit.org/show_bug.cgi?id=68558 Reviewed by Stephen White. The SharedGraphicsContext3D's internal context is lazily created and then leaked intentionally, but since the last ref is in a function-static RefPtr<> it ends up being destroyed at process exit time. This is bad, since by the time we get this far in process shutdown we can't actually cleanly run the destruction logic and we crash. Since we are explicitly leaking this for the lifetime of the process there's no point in keeping it in a RefPtr<> * platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::get): TBR=jamesr@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9529 lines, -11 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +9527 lines, -9 lines 0 comments Download
M Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
8 years, 4 months ago (2011-09-23 17:09:48 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698