Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 801993002: Delete ffmpeg_unittests. (Closed)

Created:
6 years ago by scherkus (not reviewing)
Modified:
6 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete ffmpeg_unittests. They've been supplanted by ffmpeg_regression_tests. They also crash when you run them. TBR=glider Committed: https://crrev.com/2ea2305f8d6417b49a2461f56a9069e456095609 Cr-Commit-Position: refs/heads/master@{#308227}

Patch Set 1 #

Patch Set 2 : fix valgrind script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -627 lines) Patch
M media/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D media/ffmpeg/ffmpeg_unittest.cc View 1 chunk +0 lines, -589 lines 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
scherkus (not reviewing)
6 years ago (2014-12-12 23:53:28 UTC) #2
wolenetz
lgtm %: 1. it looks like tools/valgrind/chrome_tests.py also will need update to remove 'ffmpeg' and ...
6 years ago (2014-12-13 00:00:38 UTC) #3
scherkus (not reviewing)
glider: FYI for tools/valgrind/*
6 years ago (2014-12-13 00:42:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801993002/20001
6 years ago (2014-12-13 00:44:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-13 02:23:59 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-13 02:24:32 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ea2305f8d6417b49a2461f56a9069e456095609
Cr-Commit-Position: refs/heads/master@{#308227}

Powered by Google App Engine
This is Rietveld 408576698