Introduce CompositorDependencies for RenderWidgetCompositor.

Introduce CompositorDependencies for RenderWidgetCompositor.

This interface provides whatever RenderWidgetCompositor requires
instead of going directly to RenderThreadImpl which may or may not
exist in tests.

R=piman@chromium.org
BUG=384381
Committed: https://crrev.com/6e3bf801a1d673d73df79f64887b4429cf826887
Cr-Commit-Position: refs/heads/master@{#308615}

[danakj, 2014-12-15 18:48:06]

There might be another test suite out there with a null RenderProcessImpl that I
need to inject a CompositorDeps for, bots will show, but I was able to remove a
bunch of if() branches with this :)

[danakj, 2014-12-15 19:03:27]

Moved the CompositorDepsForRenderThreadImpl to its own file (and named it
CompositorDepsImpl instead) in the last patch set.

[danakj, 2014-12-15 19:04:35]

Oh! It looks like RenderThreadImpl is null in browser tests. I did not expect
that at all... hm. Will go dig into why or where to inject something else then.

[piman, 2014-12-15 19:09:02]

LGTM, love this.

https://codereview.chromium.org/801973002/diff/140001/content/renderer/gpu/co...
File content/renderer/gpu/compositor_dependencies_impl.h (right):

https://codereview.chromium.org/801973002/diff/140001/content/renderer/gpu/co...
content/renderer/gpu/compositor_dependencies_impl.h:15: explicit
CompositorDependenciesImpl(RenderThreadImpl* render_thread);
That works, or RenderThreadImpl could directly implement CompositorDependencies.
Whatever works :)

[danakj, 2014-12-15 20:41:16]

I had to add a bunch of plumbing to let RenderViewTest do
RenderViewImpl::Create() and pass in a FakeCompositorDependencies since it
doesn't have a render thread.

Once that was all done, it seemed like it made sense to have RenderThreadImpl
own the CompositorDeps, and at that point, it's simpler to have it implement it.

For the plumbing, I wanted to pass the CompositorDeps to
RenderViewImpl/RenderWidget constructors, but layout tests override the Create
methods and have templated subclasses and it would be a disaster, so I pass it
to RenderViewImpl::Initialize() and RenderWidget::Init() and they set it on the
class there (I think this is horrible that RenderViewImpl::Initialize() doesn't
call RenderWidget::Init() or something, but yah).

PTAL

[danakj, 2014-12-15 20:46:58]

Patchset #9 (id:160001) has been deleted

[piman, 2014-12-15 21:49:05]

LGTM!

https://codereview.chromium.org/801973002/diff/200001/content/test/fake_compo...
File content/test/fake_compositor_dependencies.h (right):

https://codereview.chromium.org/801973002/diff/200001/content/test/fake_compo...
content/test/fake_compositor_dependencies.h:40: FakeRendererScheduler
renderer_scheduler_;
nit: DISALLOW_COPY_AND_ASSIGN

[danakj, 2014-12-15 22:51:08]

https://codereview.chromium.org/801973002/diff/200001/content/test/fake_compo...
File content/test/fake_compositor_dependencies.cc (right):

https://codereview.chromium.org/801973002/diff/200001/content/test/fake_compo...
content/test/fake_compositor_dependencies.cc:75:
FakeCompositorDependencies::CreateExternalBeginFrameSource(int routing_id) {
On OS_ANDROID we do call and expect to get something back from this, so it
crashes.

I moved the FakeExternalBeginFrameSource (was ExternalBeginFrameSourceForTests)
out from cc/test/layer_tree_test.cc into its own file in cc/test/ and return an
instance of that here. Then the tests that call here pass on android for me.

[danakj, 2014-12-15 22:53:03]

Patchset #10 (id:200001) has been deleted

[danakj, 2014-12-15 22:53:09]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-12-15 22:54:11]

Patchset #10 (id:220001) has been deleted

[danakj, 2014-12-15 22:54:19]

Patchset #10 (id:220001) has been deleted

[danakj, 2014-12-15 22:54:29]

Patchset #10 (id:220001) has been deleted

[danakj, 2014-12-15 22:54:41]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-12-15 22:55:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/801973002/240001

[commit-bot: I haz the power, 2014-12-15 23:11:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-15 23:11:42]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2014-12-16 16:23:47]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-12-16 16:24:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/801973002/260001

[commit-bot: I haz the power, 2014-12-16 16:40:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 16:40:05]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2014-12-16 16:50:06]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-12-16 16:51:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/801973002/280001

[commit-bot: I haz the power, 2014-12-16 17:01:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 17:01:08]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2014-12-16 17:04:37]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-12-16 17:05:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/801973002/320001

[commit-bot: I haz the power, 2014-12-16 18:28:13]

Committed patchset #14 (id:320001)

[commit-bot: I haz the power, 2014-12-16 18:29:01]

Patchset 14 (id:??) landed as
https://crrev.com/6e3bf801a1d673d73df79f64887b4429cf826887
Cr-Commit-Position: refs/heads/master@{#308615}